FYST-1469 Update misc NC (+ global) copy #5285
Conversation
…Y to accommodate differing title for NC
|
Heroku app: https://gyr-review-app-5285-5baace8c6b47.herokuapp.com/ |
|
all tests passing except for |
…opy-for-translations
…opy-for-translations
| <%= render partial: "state_file/questions/eligible/#{current_state_code}_credits_unsupported" %> | ||
| </div> | ||
| </div> | ||
| <%= render partial: "state_file/questions/eligible/#{current_state_code}_credits_unsupported" %> |
There was a problem hiding this comment.
the reveal__button text is something different for nc now, so making it go into the respective partials seemed like a good solution
| @@ -76,8 +76,8 @@ def state_intake_class_names | |||
| submission_builder_class: SubmissionBuilder::Ty2022::States::Az::AzReturnXml, | |||
| survey_link: "https://codeforamerica.co1.qualtrics.com/jfe/form/SV_0v0BnYNRoLIqzhY", | |||
| submission_type: "Form140", | |||
| tax_payment_info_text: "https://azdor.gov/make-payment-online", | |||
| tax_payment_info_url: "https://azdor.gov/making-payments-late-payments-and-filing-extensions", | |||
There was a problem hiding this comment.
based on the app/views/state_file/questions/taxes_owed/edit.html.erb implementation, looks like tax_payment_url is the link text and tax_payment_info_url is the actual link we want to navigate to. This was not being used in the return_status, so making that consistent
Q here waiting on confirmation from Madison
| direct_deposit: Direct deposit (fastest) | ||
| mail: Mail my payment (slower) | ||
| direct_deposit: By direct deposit (fastest) | ||
| mail: By mail (slower) |
There was a problem hiding this comment.
recognizing this is a cross-state change, asking if this is what we want for all states:
| tax_refund_url: "https://eservices.dor.nc.gov/wheresmyrefund/SelectionServlet", | ||
| department_of_taxation: "North Carolina Department of Revenue", | ||
| department_of_taxation: "N.C. Department of Revenue", |
There was a problem hiding this comment.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
state_code == "nc"logictax_payment_info_textas the displayed link text -- confirming with Madison right now whether this was intended to mimic taxes_owed page for all statesHow to test?
N.C.instead ofNorth Carolina), this impacts a handful of cases, double checking with Madison if this is really something we want to change.Screenshots (for visual changes)