Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GYR1-604 Add dependent IP PIN question to dependent screen #5262

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

spompea-cfa
Copy link
Contributor

@spompea-cfa spompea-cfa commented Dec 20, 2024

Link to JIRA issue

Is PM acceptance required?

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Just added one checkbox to the dependent screen/form
  • There was already a has_ip_pin column on the dependent table, so database changes were needed.

How to test?

  • Check that when using the dependent form, the IP PIN checkbox looks good and that the data element persists when going back to that dependent entry again (e.g., to edit).

Screenshots (for visual changes)

  • Before: see flows/gyr
  • After:
ip pin checkbox on dependent screen EN - Screenshot 2024-12-19 at 8 11 17 PM ip pin checkbox on dependent screen ES -Screenshot 2024-12-19 at 8 12 14 PM

Copy link

Heroku app: https://gyr-review-app-5262-83e5f94079af.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5262 (optionally add --tail)

@spompea-cfa spompea-cfa force-pushed the gyr1-604-dependent-ip-pin-question branch from ed9d842 to 4c0c935 Compare December 20, 2024 01:48
@spompea-cfa spompea-cfa force-pushed the gyr1-604-dependent-ip-pin-question branch from be938bf to 08fc7a5 Compare December 20, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant