Skip to content

Commit

Permalink
Add dependent IP PIN question to dependent screen
Browse files Browse the repository at this point in the history
  • Loading branch information
spompea-cfa committed Dec 20, 2024
1 parent 0eec131 commit 4c0c935
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions app/controllers/questions/dependents_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ def dependent_params
:north_american_resident,
:disabled,
:was_married,
:has_ip_pin,
]
permitted_params = params.require(:dependent).permit(
*dependent_attribute_keys, *birth_date_param_keys
Expand Down
1 change: 1 addition & 0 deletions app/views/questions/dependents/_form.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
<%= f.cfa_checkbox(:us_citizen, t("views.dependents.form.was_not_citizen"), options: {checked_value: "no", unchecked_value: "yes"}) %>
<%= f.cfa_checkbox(:north_american_resident, t("views.dependents.form.north_american_resident"), options: {checked_value: "no", unchecked_value: "yes"}) %>
<%= f.cfa_checkbox(:disabled, t("views.dependents.form.disabled"), options: {checked_value: "yes", unchecked_value: "no"}) %>
<%= f.cfa_checkbox(:has_ip_pin, t("views.dependents.form.has_ip_pin"), options: {checked_value: "yes", unchecked_value: "no"}) %>
</div>

<% if @allow_deletion %>
Expand Down
1 change: 1 addition & 0 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5328,6 +5328,7 @@ en:
delete_cta: Remove this person
disabled: Permanently disabled
first_name: First name
has_ip_pin: Has been issued an IP PIN
last_name: Last name
life_circumstances: Select any cases that describe their life this past year
life_circumstances_help: We need these answers to determine which tax credits you may qualify for.
Expand Down
1 change: 1 addition & 0 deletions config/locales/es.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5311,6 +5311,7 @@ es:
delete_cta: Eliminar a esta persona
disabled: Con discapacidad permanente
first_name: Nombre
has_ip_pin: Se le emitió un IP PIN
last_name: Apellido
life_circumstances: Selecciona cualesquiera casos que describan sus vidas en el último año
life_circumstances_help: Necesitamos estas respuestas para determinar para cuáles créditos tributarios te puedes calificar.
Expand Down
5 changes: 3 additions & 2 deletions spec/lib/pdf_filler/md_el101_pdf_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
let(:intake) { create(:state_file_md_intake) }
let(:submission) { create :efile_submission, tax_return: nil, data_source: intake }
let(:pdf) { described_class.new(submission) }
let(:expected_signature_date) { DateTime.now.in_time_zone(StateFile::StateInformationService.timezone('md')).strftime("%F") }

describe "#hash_for_pdf" do
let(:file_path) { described_class.new(submission).output_file.path }
Expand Down Expand Up @@ -33,7 +34,7 @@
expect(pdf_fields["ERO firm name"]).to eq "FileYourStateTaxes"
expect(pdf_fields["to enter or generate my PIN"]).to eq "23456"
expect(pdf_fields["Primary signature"]).to eq "Mary Lando"
expect(pdf_fields["Date"]).to eq Date.today.strftime("%F")
expect(pdf_fields["Date"]).to eq expected_signature_date
expect(pdf_fields["Spouses First Name"]).to eq("")
expect(pdf_fields["Spouse MI"]).to eq("")
expect(pdf_fields["Spouses Last Name"]).to eq("")
Expand Down Expand Up @@ -85,7 +86,7 @@
expect(pdf_fields["ERO firm name_2"]).to eq "FileYourStateTaxes"
expect(pdf_fields["to enter or generate my PIN_2"]).to eq "11111"
expect(pdf_fields["Spouses signature"]).to eq "Marty Lando"
expect(pdf_fields["Date_2"]).to eq Date.today.strftime("%F")
expect(pdf_fields["Date_2"]).to eq expected_signature_date
end
end
end
Expand Down

0 comments on commit 4c0c935

Please sign in to comment.