generated from cloudoperators/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): pageheader custom logo #363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update styles to target universal child of container
🦋 Changeset detectedLatest commit: e5b9c59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
|
edda
requested changes
Sep 16, 2024
packages/ui-components/src/components/PageHeader/PageHeader.component.tsx
Outdated
Show resolved
Hide resolved
packages/ui-components/src/components/PageHeader/PageHeader.component.tsx
Outdated
Show resolved
Hide resolved
edda
previously approved these changes
Sep 19, 2024
edda
approved these changes
Sep 19, 2024
andypf
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(ui): Pageheader custom logo
This is a duplication of PR #358 that we decided to close during the merge problems.
Allow users to pass a custom logo component to the PageHeader and render it.
Changes Made
logo
prop that accepts a component to render in a slottrue
orundefined
false
ornull
Related Issues
Screenshots (if applicable)
Testing Instructions
npm i
npm run test
/npm run test PageHeader
Checklist