Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): pageheader custom logo #363

Merged
merged 20 commits into from
Sep 19, 2024
Merged

feat(ui): pageheader custom logo #363

merged 20 commits into from
Sep 19, 2024

Conversation

barsukov
Copy link
Contributor

feat(ui): Pageheader custom logo
This is a duplication of PR #358 that we decided to close during the merge problems.

Allow users to pass a custom logo component to the PageHeader and render it.

Changes Made

  • use grid layout in header instead of flexbox as it gives us better control to make sure the logo is scaled correctly while keeping its original aspect ratio
  • add a logo prop that accepts a component to render in a slot
  • render the default Juno logo if true or undefined
  • do not render any logo at all if false or null

Related Issues

Screenshots (if applicable)

Testing Instructions

  1. npm i
  2. npm run test / npm run test PageHeader

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@barsukov barsukov added the enhancement New feature or request label Sep 16, 2024
@barsukov barsukov self-assigned this Sep 16, 2024
@barsukov barsukov requested review from franzheidl and a team as code owners September 16, 2024 10:37
Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: e5b9c59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@barsukov barsukov mentioned this pull request Sep 16, 2024
6 tasks
Copy link
Contributor

github-actions bot commented Sep 16, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-19 09:07 UTC

@barsukov barsukov enabled auto-merge (squash) September 18, 2024 17:59
edda
edda previously approved these changes Sep 19, 2024
@barsukov barsukov requested a review from edda September 19, 2024 08:57
@barsukov barsukov merged commit 68e3984 into main Sep 19, 2024
14 checks passed
@barsukov barsukov deleted the wowa-franz-logo-fix branch September 19, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants