Skip to content

Commit

Permalink
feat(ui): pageheader custom logo (#363)
Browse files Browse the repository at this point in the history
* feat(ui): add logo prop

* update styles to target universal child of container

* feat(ui): PageHeader: update logo logic

* feat(ui): PageHeader: add custom logo stories

* feat(ui): PageHeader: use grid layout

* feat(ui): paheader custom logo: update test

* feat(ui): add tests for custom logo

* feat(ui): PageHeader: add and update documentation

* Create changeset-pageheader-custom-logo.md

* chore(ui): fix tests for PageHeader

* chore(ui): fix lint in greenhouse

* chore(ui): updates PageHeader description

* chore(ui): fix PageHeader stories

* chore(ui): fix PageHeader types

---------

Co-authored-by: Franz Heidl <[email protected]>
Co-authored-by: Esther Schmitz <[email protected]>
  • Loading branch information
3 people authored Sep 19, 2024
1 parent fbe014f commit 68e3984
Show file tree
Hide file tree
Showing 17 changed files with 1,271 additions and 1,175 deletions.
8 changes: 8 additions & 0 deletions .changeset/changeset-pageheader-custom-logo.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@cloudoperators/juno-ui-components": minor
---

feat(ui): add pageheader custom logo

* add `logo` prop that accepts a custom logo as a component to be rendered in a slot
* move grid layout for pageheader for robust logo placement and sizing
5 changes: 1 addition & 4 deletions .github/workflows/ci-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ on:
- opened
- synchronize
- reopened
push:
branches-ignore:
- main # Ignore the main branch because all the checks are already done in the 'Release' workflow
# Trigger after the 'Release' workflow completes
workflow_run:
workflows: ["Release"]
Expand All @@ -20,7 +17,7 @@ permissions:
pull-requests: write
actions: read
checks: write
statuses: write
statuses: write

env:
HUSKY: 0
Expand Down
1 change: 0 additions & 1 deletion apps/greenhouse/apps/cluster-admin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"babel-jest": "^29.3.1",
"babel-plugin-transform-import-meta": "^2.2.0",
"esbuild": "^0.17.19",
"eslint-plugin-react-hooks": "^4.6.0",
"jest": "^29.7.0",
"jest-environment-jsdom": "^29.3.1",
"postcss": "^8.4.21",
Expand Down
2 changes: 1 addition & 1 deletion apps/greenhouse/src/hooks/useAuthentication.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ function parseMockData(mockData) {
try {
// First, attempt to decode from base64 and parse as JSON
token = JSON.parse(atob(mockData))
} catch (base64Error) {
} catch (_base64Error) {
//Failed to parse mock token from Base64"

// Fallback to parsing mockData directly as JSON
Expand Down
Loading

0 comments on commit 68e3984

Please sign in to comment.