Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add new JunoUI logo in Storybook and PageHeader component #304

Merged
merged 9 commits into from
Sep 9, 2024

Conversation

MartinS-git
Copy link
Contributor

@MartinS-git MartinS-git commented Sep 5, 2024

Summary

  1. Replaced logo in Storybook UI (Sidebar and Favicon). Also changed style and position of version number.
  2. Replaced SAP Logo in 'PageHeader' component with new logo

Related Issues

#169

Screenshots (if applicable)

image

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@MartinS-git MartinS-git requested review from franzheidl and a team as code owners September 5, 2024 13:11
Copy link

changeset-bot bot commented Sep 5, 2024

🦋 Changeset detected

Latest commit: 8e45e9c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 5, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-09 15:37 UTC

Copy link
Contributor

@edda edda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!
Two things:

  1. Please remove the SAP logo svg
  2. Please add a changeset (change level minor)

@MartinS-git MartinS-git changed the title Logo storybook feat(ui): Add new JunoUI logo in Storybook and PageHeader component Sep 6, 2024
@MartinS-git MartinS-git changed the title feat(ui): Add new JunoUI logo in Storybook and PageHeader component feat(ui): add new JunoUI logo in Storybook and PageHeader component Sep 6, 2024
edda
edda previously approved these changes Sep 9, 2024
@edda edda merged commit 8449754 into main Sep 9, 2024
14 checks passed
@edda edda deleted the logo-storybook branch September 9, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants