Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature](ui): PageHeader - Allow custom brand logo in #169

Closed
2 of 5 tasks
Tracked by #62
edda opened this issue Aug 2, 2024 · 1 comment
Closed
2 of 5 tasks
Tracked by #62

[Feature](ui): PageHeader - Allow custom brand logo in #169

edda opened this issue Aug 2, 2024 · 1 comment
Assignees
@franzheidl @MartinS-git
Labels
enhancement New feature or request

Comments

@edda
Copy link
Contributor

edda commented Aug 2, 2024 •
edited by MartinS-git
Loading

Description
The PageHeader component should allow customization of the brand logo it renders.

Proposed Solution

  • Allow passing via prop a custom brand logo as a component
  • logo -> true (default), false (no logo at all), or component (slot), undefined -> TBD
  • Design default logo to be used instead of SAP Logo
  • in default case show new default logo
  • Allow for rendering no logo at all
@edda edda added the enhancement New feature or request label Aug 2, 2024
@edda edda mentioned this issue Jul 31, 2024
Open
19 tasks
@MartinS-git MartinS-git mentioned this issue Sep 5, 2024
Merged
6 tasks
@MartinS-git
Copy link
Contributor

Replaced SAP logo and Favicon in Storybook and in PageHeader component with PR: #304

@franzheidl franzheidl mentioned this issue Sep 13, 2024
Closed
6 tasks
@barsukov barsukov mentioned this issue Sep 16, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franzheidl franzheidl

@MartinS-git MartinS-git

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@franzheidl @edda @barsukov @MartinS-git