Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdnjs should always be lowercase #15348

Open
wants to merge 9 commits into
base: production
Choose a base branch
from
Open

cdnjs should always be lowercase #15348

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a44f037
cdnjs should always be lowercase
MattIPv4 Jun 26, 2024
873ee25
Add Vale rule for brand names
MattIPv4 Jun 26, 2024
99b5950
Improve Cloudflare capitalization checking
MattIPv4 Jun 27, 2024
9cd0393
Add rules for GitHub/GitLab capitalization
MattIPv4 Jun 27, 2024
f1e247e
Don't use capture groups in Vale rule
MattIPv4 Jun 27, 2024
e6b496b
Expect whitespace around brand names
MattIPv4 Jun 30, 2024
eeaa768
Ignore specific cases, don't require whitespace
MattIPv4 Jul 3, 2024
6b5e891
Add Next.js
MattIPv4 Jul 3, 2024
62ed229
Only exclude create- for Cloudflare
MattIPv4 Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/styles/cloudflare/BrandNames.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
# Warning: cloudflare.BrandNames
#
# Suggests correct spelling and capitalization for brand names.
#
# For a list of all options, see https://vale.sh/docs/topics/styles/

extends: substitution
message: "**Warning**: Use correct brand name: '%s' instead of '%s'."
level: warning
ignorecase: false
swap:
(?!Cloudflare)([cC]loud[fF]lare): Cloudflare
(?!cdnjs)([cC][dD][nN]\.?[jJ][sS]): cdnjs
MattIPv4 marked this conversation as resolved.
Show resolved Hide resolved
(?!GitHub)([gG]it\s?[hH]ub): GitHub
(?!GitLab)([gG]it\s?[lL]ab): GitLab
MattIPv4 marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion content/logs/reference/pathing-status.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Cloudflare issues the following **Edge Pathing Statuses**:
- `bic` (browser integrity check)
- `hot` (hotlink protection)
- `macro` (the reputation list)
- `skip` (Always Online or CDNJS resources)
- `skip` (Always Online or cdnjs resources)
- `user` (user firewall rule)

For example:
Expand Down
2 changes: 1 addition & 1 deletion content/waf/tools/replace-insecure-js-libraries.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Additionally, if you are defining a CSP via HTML `meta` tag, you must either tur

## How it works

When turned on, Cloudflare will check HTTP(S) proxied traffic for `script` tags with an `src` attribute pointing to a potentially insecure service and replace the `src` value with the equivalent link hosted under [CDNJS](https://cdnjs.cloudflare.com/).
When turned on, Cloudflare will check HTTP(S) proxied traffic for `script` tags with an `src` attribute pointing to a potentially insecure service and replace the `src` value with the equivalent link hosted under [cdnjs](https://cdnjs.cloudflare.com/).

The rewritten URL will keep the original URL scheme (`http://` or `https://`).

Expand Down
Loading