-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdnjs should always be lowercase #15348
base: production
Are you sure you want to change the base?
Conversation
Co-authored-by: Greg Brimble <[email protected]>
Co-authored-by: Greg Brimble <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a great addition to me! Again, will defer to @KianNH for final approval :)
Not sure whitespace alone is enough. What about something like |
Hmm, I'm not sure there's going to be a good way to do that, while still avoiding what Kian flagged, unless we're going to allow some non-alphanumeric chars but not others (e.g. allow |
I'd personally think that we'd want to warn on all uses, and try to exclude certain ones which we know are valid. The Microsoft Work/Google Docs spellcheck dictionary approach. So I'd suggest |
Oh, |
Couldn't see any existing rule for enforcing correct capitalization of brand names (was surprised given Cloudflare vs. CloudFlare), so I've added one as part of this. Haven't written a Vale rule before so it could be wrong!