Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdnjs should always be lowercase #15348

Open
wants to merge 9 commits into
base: production
Choose a base branch
from

Conversation

MattIPv4
Copy link
Contributor

Couldn't see any existing rule for enforcing correct capitalization of brand names (was surprised given Cloudflare vs. CloudFlare), so I've added one as part of this. Haven't written a Vale rule before so it could be wrong!

Copy link
Member

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great addition to me! Again, will defer to @KianNH for final approval :)

.github/styles/cloudflare/BrandNames.yml Outdated Show resolved Hide resolved
@MattIPv4 MattIPv4 requested a review from KianNH June 30, 2024 00:48
@GregBrimble
Copy link
Member

Not sure whitespace alone is enough. What about something like Welcome to Cloudflare., platforms like: GitHub, GitLab, etc. and links ([GitHub](https://github.com/))

@MattIPv4
Copy link
Contributor Author

MattIPv4 commented Jul 2, 2024

Hmm, I'm not sure there's going to be a good way to do that, while still avoiding what Kian flagged, unless we're going to allow some non-alphanumeric chars but not others (e.g. allow [],., but not -/)?

@GregBrimble
Copy link
Member

I'd personally think that we'd want to warn on all uses, and try to exclude certain ones which we know are valid. The Microsoft Work/Google Docs spellcheck dictionary approach.

So I'd suggest (?<!https:\/\/[^\s]+)(?<!create-)(?!GitLab)(?:[gG]it\s?[lL]ab) and equivalents.

@GregBrimble
Copy link
Member

Oh, Next.js is another one I see get mis-stylized all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet