Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in README: Azure -> GCP #53

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

maxhardt
Copy link
Contributor

No description provided.

Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maxhardt,

Good spot, thank you for making this change.

Just one addition if possible - could you make the same change in doc_fragments/header.md?
The README is automatically generated with the terraform-docs command.
It uses the contents of doc_fragments/header.md in the module plus the Terraform input and output specification from the code.

@maxhardt
Copy link
Contributor Author

added!

Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved.

@jimright jimright merged commit fa607ec into cloudera-labs:main Jan 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants