Changed host ip lookup to IPv4

[maxhardt]

No description provided.

[jimright]

Hi @maxhardt,

Thanks for handling this. See comments for one set of changes required to handle the case where the ingress_extra_cidrs_and_ports input variable is set.

Also it looks like your commit is missing DCO signoff (you had this on cloudera-labs/terraform-cdp-modules#53 so might just be a git config setting).

[maxhardt]

Thanks for catching these @jimright, followed your suggestion in the latest commits. Would be great to have some rudimentary (unit) testing to catch these when developing as well, happy to contribute! 🧪

[jimright]

Thanks for catching these @jimright, followed your suggestion in the latest commits. Would be great to have some rudimentary (unit) testing to catch these when developing as well, happy to contribute! 🧪

Yes, the addition of some testing is great suggestion and would definitely help to catch potential issues or regressions early.
We've done some terratest for another project but Terraform have also recently released a native terraform test framework that should help. Here's an overview - https://www.hashicorp.com/blog/testing-hashicorp-terraform. Let's review this and see what we can achieve.

[jimright]

Looks good. Approved.