Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 50 #63

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Fix issue 50 #63

merged 2 commits into from
Jul 24, 2024

Conversation

slott56
Copy link
Collaborator

@slott56 slott56 commented May 21, 2024

Do proper partial evaluation of e ? x1 : x2. If e is true, only x1 is evaluated; if e is false, only x2 is evaluated.

This fixes issue #50

Do proper partial evaluation of e ? x1 : x2. If e is true, only x1 is evaluated; if e is false, only x2 is evaluated.
@slott56 slott56 requested review from kapilt and PratMis May 21, 2024 19:51
@slott56 slott56 requested a review from KueZie May 21, 2024 20:42
@slott56 slott56 self-assigned this May 21, 2024
This assures that `true ? 6 : invalid` and `false ? invalid : 7` never evaluate the invalid nodes.
Copy link
Collaborator

@KueZie KueZie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the introduction of the DO_NOT_EVALUATE test case.

Copy link
Collaborator

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kapilt kapilt merged commit 84077d2 into main Jul 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants