Evaluate a condition branch only if needed #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[The CEL language definition](https://github.com/google/cel-spec/blob/master/doc/langdef.md#logical-operators) suggests: > To get traditional left-to-right short-circuiting evaluation of logical operators, as in C or other languages (also called "McCarthy Evaluation"), the expression e1 && e2 can be rewritten `e1 ? e2 : false`. Similarly, `e1 || e2` can be rewritten `e1 ? true : e2`. `cel-python` used to evaluate the full tree before deciding if a branch will be used or not. This PR only evaluates a branch if selected by the condition. Fixes issue cloud-custodian#50
|
thanks for the pr, lgtm although a test would be appreciated, would also appreciate a look by @slott56 |
|
See #63 which fixes this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CEL language definition suggests:
cel-pythonused to evaluate the full tree before deciding if a branch will be used or not. This PR only evaluates a branch if selected by the condition.Fixes #50