(#3566) Ensure package download from authed source #3577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Credential lookup logic to account for the scenario where NuGet has forgotten the credentials for the source between determining the download Uri and trying to download from it. In this instance the target Uri is a superstring of the source Uri (that is for a source of `https://repo/repository/my-repository/`, the download might be `https://repo/repository/my-repository/my-package/1.1.1`). This would not match the credential lookup, but it should use the configured credential.
|
PR is draft while I work out a few other Test Kitchen issues. |
This commit fixes hanging tests and bring the changes from 981a5d9 into the support branch. Going forward, the official signing certificate will only be in play on tagged builds. As such, we can't easily assert on the certificate thumbprint. Instead, let's check on the Issuer name, and if the official one, check for certificate being valid, otherwise let's assert on it not being correct. This is similar to what is now done elsewhere when checking for signatures, i.e. in CCR and Chocolatey.Cake.Recipe.
AdmiringWorm
approved these changes
Nov 29, 2024
AdmiringWorm
requested changes
Nov 29, 2024
Update the wording used on push failures to capture accurate results even with slightly different wording between Team City and local runs.
When upgrading Chocolatey, if the certificate subject doesn't match a known Chocolatey certificate we don't replace the file. The certificate used for signing changed slightly, this adds the new subject to the check.
AdmiringWorm
approved these changes
Nov 29, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Update the Credential lookup logic to account for the scenario where NuGet has forgotten the credentials for the source between determining the download Uri and trying to download from it. In this instance the target Uri is a superstring of the source Uri (that is for a source of
https://repo/repository/my-repository/, the download might behttps://repo/repository/my-repository/my-package/1.1.1). This would not match the credential lookup, but it should use the configured credential.Motivation and Context
Sometimes NuGet forgets where it's downloading from, and needs to get the credentials again.
Testing
Ran tests through Test Kitchen.
Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #3566