Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Update Authenticode Signature #3578

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

corbob
Copy link
Member

@corbob corbob commented Nov 29, 2024

Description Of Changes

This commit takes the newly signed PowerShell scripts from the build server and adds them into the source code repository. A new process for re-signing the files will be followed to ensure that the signature remains in tact.

Motivation and Context

Keep the signature up to date.

Testing

N/A

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

#3577

@corbob
Copy link
Member Author

corbob commented Nov 29, 2024

This is in draft because the commit is wrong. The signature is still broken. I wanted to get a PR link to share before I actually had the signed files.

@AdmiringWorm AdmiringWorm self-requested a review November 29, 2024 17:38
This commit takes the newly signed PowerShell scripts from the build
server and adds them into the source code repository.  A new process
for re-signing the files will be followed to ensure that the signature
remains in tact.
@corbob corbob marked this pull request as ready for review November 29, 2024 17:41
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdmiringWorm AdmiringWorm merged commit 1b5f16d into chocolatey:hotfix/1.4.1 Nov 29, 2024
5 checks passed
@corbob corbob deleted the update-signatures branch November 29, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants