(#2829) Adds Basic choco license Command (WIP) #2847
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiringWorm
requested changes
Oct 5, 2022
src/chocolatey/infrastructure.app/commands/ChocolateyLicenseCommand.cs
Outdated
Show resolved
Hide resolved
src/chocolatey/infrastructure.app/commands/ChocolateyLicenseCommand.cs
Outdated
Show resolved
Hide resolved
src/chocolatey/infrastructure.app/commands/ChocolateyLicenseCommand.cs
Outdated
Show resolved
Hide resolved
src/chocolatey/infrastructure.app/commands/ChocolateyLicenseCommand.cs
Outdated
Show resolved
Hide resolved
src/chocolatey/infrastructure.app/commands/ChocolateyLicenseCommand.cs
Outdated
Show resolved
Hide resolved
src/chocolatey/infrastructure.app/commands/ChocolateyLicenseCommand.cs
Outdated
Show resolved
Hide resolved
src/chocolatey/infrastructure.app/commands/ChocolateyLicenseCommand.cs
Outdated
Show resolved
Hide resolved
This commit introduces a new command to Chocolatey, `license`. Currently, the functionality is limited, and it will only display details on the current license.
JPRuskin
force-pushed
the
license-command
branch
from
0febeca
to
f842a18
Compare
corbob
reviewed
Oct 12, 2022
| var nodeCount = parse_node_count(ourLicense.Name); | ||
| var logger = config.RegularOutput ? ChocolateyLoggers.Normal : ChocolateyLoggers.LogFileOnly; | ||
|
|
||
| if (ourLicense.LicenseType == ChocolateyLicenseType.Foss) |
There was a problem hiding this comment.
It looks like we can use is_licensed_version(): https://github.com/chocolatey/choco/blob/develop/src/chocolatey/infrastructure/licensing/ChocolateyLicense.cs#L36
JPRuskin
commented
Oct 28, 2022
| } | ||
|
|
||
| return null; | ||
|
|
There was a problem hiding this comment.
Gary wouldn't approve this.
Suggested change
There was a problem hiding this comment.
He also suggests using the regex used in other parsing parts, for consistency.
private static readonly Regex _licenseCountRegex = new(@"\[.*?(?<licensedMachineCount>\d+).*?\]");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR adds a delightful new command,
choco license.It should offer read and write, but at the moment just offers a basic output of the current license.
It doesn't yet have tests, either.
Motivation and Context
This has been requested by awesome folk!
Testing
Change Types Made
Related Issue
Fixes #2829
Change Checklist