[pull] master from verilator:master #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
These show spurious errors with some toolchains due to an address sanitizer bug.
`$psprintf` is a non-standard system function present in some other simulators, and has been rejected for standardization by IEEE because of being basically the same as `$sformatf`. To encourage users to fix their codebase, a warning is emitted by default, but it gets otherwise interpreted as `$sformatf` as early as during lexing. Signed-off-by: Arkadiusz Kozdra <[email protected]> * wording/formatting Signed-off-by: Arkadiusz Kozdra <[email protected]> --------- Signed-off-by: Arkadiusz Kozdra <[email protected]>
Signed-off-by: Arkadiusz Kozdra <[email protected]>
The BITS_PER_DIGIT macro value differs between SystemC versions, thus referencing it directly is required.
After the V3Timing refactoring the V3SchedTiming phase could apparently move away all awaits from a coroutine without adding a co_return statement. Signed-off-by: Arkadiusz Kozdra <[email protected]>
Signed-off-by: Bartłomiej Chmiel <[email protected]>
This may cause some additional SIDEEFFECT warnings that previously were not shown.
Signed-off-by: Arkadiusz Kozdra <[email protected]>
…ino] Co-authored-by: Seth Pellegrino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )