[fix] Raise a fatal error in the ROM if max. limit of measurements is crossed #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… crossed. This change updates the logic when a stash measurement is requested beyond the max. supported. The new code raises a fatal error instead of continuing the boot sequence. This change addresses issue# 1590.
mhatrevi
requested review from
ajisaxena,
vsonims,
korran and
JohnTraverAmd
as code owners
|
Left a comment on #1590 about this. This feels more like a behavior change than a bugfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the logic when a stash measurement is requested beyond the max. supported. The new code raises a fatal error instead of continuing the boot sequence.
This change addresses issue# 1590.