Implement API for requesting/retrieving Caliptra's IDEVID CSR. #1583
Conversation
rusty1968
force-pushed
the
libcaliptra-csr
branch
from
806b49b
to
a33e260
Compare
rusty1968
changed the title
rusty1968
requested review from
fdamato,
wmaroneAMD,
JohnTraverAmd,
jlmahowa-amd,
korran and
mhatrevi
as code owners
| uint8_t idev_csr_bytes[IDEV_CSR_LEN] = { | ||
| 48, 130, 1, 183, 48, 130, 1, 62, 2, 1, 0, 48, 105, 49, 28, 48, 26, 6, | ||
| 3, 85, 4, 3, 12, 19, 67, 97, 108, 105, 112, 116, 114, 97, 32, 49, 46, | ||
| 48, 32, 73, 68, 101, 118, 73, 68, 49, 73, 48, 71, 6, 3, 85, 4, 5, 19, |
There was a problem hiding this comment.
where does this CSR array come from ?
There was a problem hiding this comment.
from the idev_csr_der file in smoke test data.
There was a problem hiding this comment.
It might be worth either
- Reading it from a file
- Adding a comment with the filepath to where this comes from
libcaliptra/examples/generic/main.c
Outdated
| { | ||
| int status; | ||
|
|
||
| // Initialize FSM GO | ||
| caliptra_bootfsm_go(); | ||
|
|
||
libcaliptra/src/caliptra_api.c
Outdated
| { | ||
| if (caliptra_is_csr_ready()) { | ||
| break; | ||
| } |
There was a problem hiding this comment.
can we add a timeout here ?
There was a problem hiding this comment.
I don't think libcaliptra can have any platform-agnostic way of supporting timing. If the caller wants a timeout, I think they would need to directly use caliptra_is_csr_ready() in their own generic test-with-timeout function/macro.
There was a problem hiding this comment.
I removed this function from the public api and left it as test fixture.
libcaliptra/src/caliptra_mbox.h
Outdated
| @@ -128,7 +128,7 @@ static inline bool caliptra_mbox_is_busy(void) | |||
|
|
|||
| static inline uint8_t caliptra_mbox_read_status_fsm(void) | |||
| { | |||
| return (uint8_t)(caliptra_mbox_read(MBOX_CSR_MBOX_STATUS) >> 16 & MBOX_CSR_MBOX_STATUS_STATUS_MASK); | |||
| return (uint8_t)(caliptra_mbox_read(MBOX_CSR_MBOX_STATUS) >> 6) & 7; | |||
There was a problem hiding this comment.
i changed it to use the #defines available in the headers.
| @@ -263,7 +275,7 @@ int rt_test_all_commands() | |||
| { | |||
| int failure = 0; | |||
| uint32_t non_fatal_error; | |||
| int status = boot_to_ready_for_fw(); | |||
| int status = boot_to_ready_for_fw(false); | |||
|
|
|||
| if (status){ | |||
There was a problem hiding this comment.
why are we overriding the actual cause of failure with 1 ?
There was a problem hiding this comment.
I don't have the context. I was not the original implementer of the testbench.
rusty1968
force-pushed
the
libcaliptra-csr
branch
from
a33e260
to
1b636d5
Compare
libcaliptra/src/caliptra_api.c
Outdated
| { | ||
| if (caliptra_is_csr_ready()) { | ||
| break; | ||
| } |
There was a problem hiding this comment.
I don't think libcaliptra can have any platform-agnostic way of supporting timing. If the caller wants a timeout, I think they would need to directly use caliptra_is_csr_ready() in their own generic test-with-timeout function/macro.
rusty1968
force-pushed
the
libcaliptra-csr
branch
2 times, most recently
from
64b9c9f
to
6ddfb6c
Compare
rusty1968
force-pushed
the
libcaliptra-csr
branch
2 times, most recently
from
80095c3
to
1c74395
Compare
rusty1968
force-pushed
the
libcaliptra-csr
branch
from
1c74395
to
099fcda
Compare
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
nit: remove extra newlines
| uint8_t idev_csr_bytes[IDEV_CSR_LEN] = { | ||
| 48, 130, 1, 183, 48, 130, 1, 62, 2, 1, 0, 48, 105, 49, 28, 48, 26, 6, | ||
| 3, 85, 4, 3, 12, 19, 67, 97, 108, 105, 112, 116, 114, 97, 32, 49, 46, | ||
| 48, 32, 73, 68, 101, 118, 73, 68, 49, 73, 48, 71, 6, 3, 85, 4, 5, 19, |
There was a problem hiding this comment.
It might be worth either
- Reading it from a file
- Adding a comment with the filepath to where this comes from
This commit adds functionality to request and retrieve an IDEVID Certificate Signing Request.