-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(import): csharp support #2520
Conversation
5ca5a8a
to
f3a2d62
Compare
Signed-off-by: Deon <[email protected]>
f3a2d62
to
900103e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing integ test, see https://github.com/cdk8s-team/cdk8s-cli/blob/2.x/test/integ/init.test.ts
Ah ok this is just adding csharp to import and not as an init template. Still, we need a test for it then because its not covered by init tests. |
I don't mind which PR gets merged. My only feedback about the other PR is, where there are references to language it should be |
I am happy for either PR to get merged, I am currently using a fork in CI and would prefer a proper package to consume. If we can decide which we go with one of use can knock together a test and proceed. @haodeon I went with the conventions of each code base, |
@ScottKane ping me once you have test together or if you need guidance. |
Actually, CDK uses |
Implements missing functionality for cdk8s-team/cdk8s#118
Adds
csharp
to srcmak options.Have tested the generated code in a F# project, both importing
[email protected]
and some CRDs.