Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(import): csharp support #2520

Closed
wants to merge 2 commits into from

Conversation

haodeon
Copy link

@haodeon haodeon commented Jul 26, 2024

Implements missing functionality for cdk8s-team/cdk8s#118

Adds csharp to srcmak options.

Have tested the generated code in a F# project, both importing [email protected] and some CRDs.

@haodeon haodeon changed the title Add csharp to cli import feat: Add csharp to cli import Jul 26, 2024
@iliapolo
Copy link
Member

Looks like a we have another PR for this exact feature: #2519.

@haodeon How do you feel about reaching out to the author and deciding on the one PR we should be merging? :)

Copy link
Member

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iliapolo iliapolo changed the title feat: Add csharp to cli import feat(import): csharp support Sep 10, 2024
@iliapolo
Copy link
Member

Ah ok this is just adding csharp to import and not as an init template. Still, we need a test for it then because its not covered by init tests.

@iliapolo iliapolo added the response-requested Awaiting response from author label Sep 10, 2024
@haodeon
Copy link
Author

haodeon commented Sep 10, 2024

I don't mind which PR gets merged.

My only feedback about the other PR is, where there are references to language it should be csharp as srcmak produces csharp.

@ScottKane
Copy link

I am happy for either PR to get merged, I am currently using a fork in CI and would prefer a proper package to consume. If we can decide which we go with one of use can knock together a test and proceed.

@haodeon I went with the conventions of each code base, jsii-srcmak calls it csharp but elsewhere in cdk8s it's referred to as dotnet but I don't really care either way, it can all be consumed by any .NET language anyways.

@github-actions github-actions bot removed the response-requested Awaiting response from author label Sep 10, 2024
@iliapolo
Copy link
Member

Ok so lets go with #2519, for no good reason. As for the language, jsii refers to it as dotnet so lets go with that. Closing this one. Thanks @haodeon! and please provide any feedback you have on the other PR.

@iliapolo iliapolo closed this Sep 10, 2024
@iliapolo
Copy link
Member

@ScottKane ping me once you have test together or if you need guidance.

@iliapolo
Copy link
Member

As for the language, jsii refers to it as dotnet so lets go with that.

Actually, CDK uses charp, so lets do that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants