feat(import): csharp support #2519
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Kane <[email protected]>
iliapolo
changed the title
|
Looks like a we have another PR for this exact feature: #2520. @ScottKane How do you feel about reaching out to the author and deciding on the one PR we should be merging? :) |
iliapolo
requested changes
Sep 10, 2024
There was a problem hiding this comment.
Missing integ test. See https://github.com/cdk8s-team/cdk8s-cli/blob/2.x/test/integ/init.test.ts
iliapolo
changed the title
|
Ah ok this is just adding csharp to import and not as an init template. Still, we need a test for it then because its not covered by init tests. |
Signed-off-by: Scott Kane <[email protected]>
|
@iliapolo Integration test added and template added. I have also renamed everything to use the |
|
also |
Signed-off-by: ScottKane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for calling
jsii-srcmakwithcsharp/dotnetfromcdk8s import(REGEX applied to convert names to PascalCase where possible)