Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): destructuring error when import chart with null props #2495

Closed
wants to merge 3 commits into from
Closed

fix(helm): destructuring error when import chart with null props #2495

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b32a51
props null fix
yuriy-yarosh Jul 11, 2024
b6905d8
Merge branch '2.x' into fix-2494
iliapolo Jul 28, 2024
7d36bfe
Merge branch '2.x' into fix-2494
iliapolo Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/import/codegen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ export function generateHelmConstruct(typegen: TypeGenerator, def: HelmObjectDef
code.close('}');
code.close('}');
code.line();
code.line('const { additionalValues, ...valuesWithoutAdditionalValues } = props;');
code.line('const { additionalValues, ...valuesWithoutAdditionalValues } = props || {};');
code.line();
code.open('return {');
code.line('...valuesWithoutAdditionalValues,');
Expand All @@ -421,4 +421,4 @@ export function generateHelmConstruct(typegen: TypeGenerator, def: HelmObjectDef

function hasRequiredProps(schema: JSONSchema4):boolean | undefined {
return schema?.required && Array.isArray(schema.required) && schema.required.length > 0;
}
}
Loading