-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): destructuring error when import chart with null
props
#2495
Conversation
Signed-off-by: Yuriy Yarosh <[email protected]>
null
props
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuriy-yarosh could you also add a test for this scenario? best would be to just add the chart you identifier the issue with here:
cdk8s-cli/test/import/import-helm.test.ts
Lines 7 to 14 in 148ca1f
describe.each([ | |
'helm:https://charts.bitnami.com/bitnami/[email protected]', // Contains schema and dependencies | |
'helm:https://kubernetes.github.io/ingress-nginx/[email protected]', // Does not contain schema | |
'helm:https://lacework.github.io/helm-charts/[email protected]', | |
'helm:oci://registry-1.docker.io/bitnamicharts/[email protected]', | |
'minio:=helm:https://operator.min.io/[email protected]', | |
'helm:https://grafana.github.io/helm-charts/[email protected]', | |
])('importing helm chart %s', (testChartUrl) => { |
@yuriy-yarosh are you still available to see this through? |
@iliapolo being conscripted, so things are a bit all over the place. |
This PR has not received a response in a while and will be closed soon. If you want to keep it open, please leave a comment below @mentioning a maintainer. |
Fixes cdk8s-team/cdk8s#2139 destructuring error.