feat: do not create /bin/java symlink #752
Merged
Commits on Nov 17, 2024
-
feat: override _get_java_link_commands
Maven and Ant plugin should not create /bin/java symlink
-
doc: add rockcraft-specific docs for ant and maven
Ant and Maven plugins override build commands of craft-parts Ant and Maven plugins.
-
Commits on Nov 18, 2024
-
test: add rockcraft plugin tests
- add smoke tests for maven and ant plugins.
-
-
-
- drop unneeded property - add ant plugin targets
Commits on Nov 19, 2024
Commits on Nov 25, 2024
Commits on Nov 28, 2024
-
- use package installation to ensure /usr/bin/java is present - run jlink to replace modules
-
- we have not merged JAVA_HOME fix yet, so do basic tests that plugin works
-
- we still have to create java symlink in rockcraft yaml - the test image is fixed for amd64, so its ok to hardcode path in task.yaml
-
-
-
-
-
-
-
-
Commits on Dec 1, 2024
-
chore: rename part in ant test
ant test had part named 'maven-sample'.
-
craft-parts ant plugin description has too long lines.
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.