feat: do not create /bin/java symlink #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maven and Ant plugin should not create /bin/java symlink
Ant and Maven plugins override build commands of craft-parts Ant and Maven plugins.
- add smoke tests for maven and ant plugins.
github-actions
bot
added
the
documentation
- drop unneeded property - add ant plugin targets
|
@vpa1977 I'll review this on Thursday (I'm OOO until then) |
- use package installation to ensure /usr/bin/java is present - run jlink to replace modules
- we have not merged JAVA_HOME fix yet, so do basic tests that plugin works
- we still have to create java symlink in rockcraft yaml - the test image is fixed for amd64, so its ok to hardcode path in task.yaml
tigarmo
reviewed
Nov 28, 2024
|
@linostar please take a look |
linostar
requested changes
Nov 29, 2024
tigarmo
reviewed
Nov 29, 2024
Reuse common docs for maven and ant plugins.
ant test had part named 'maven-sample'.
Validate that /bin/java is a valid command
craft-parts ant plugin description has too long lines.
|
I have added: canonical/craft-parts#916 so that I could make documentation override less horrible in the followup PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overrides maven and ant plugin to avoid creating /bin/java symlink : canonical/craft-parts#813
This allows to use those plugins to build rocks.
The plugins still need to set JAVA_HOME manually which is addressed by canonical/craft-parts#895
Raised #754 to address the linter error.