Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS-4747 Remove the jimm snap before attempting to install it. #998

Merged
merged 3 commits into from
Jul 13, 2023
Merged

CSS-4747 Remove the jimm snap before attempting to install it. #998

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1cf7df
Remove the jimm snap before attempting to install it.
alesstimec Jul 12, 2023
e754c43
Merge branch 'main' into charm-jimm-snap-install-fix-01
alesstimec Jul 12, 2023
bebbc2f
Merge branch 'main' into charm-jimm-snap-install-fix-01
alesstimec Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charms/jimm/src/charm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,9 @@ def _install_snap(self):
if not path:
self.unit.status = BlockedStatus("waiting for jimm-snap resource")
return
# remove the jimm snap if it is already installed.
self._snap("remove", "jimm")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we not do a snap refresh instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jimm snap is not installed from snapstore.. but instead from a resource.. i don't see a way to say "refresh from this path" using snaps

# install the new jimm snap.
self._snap("install", "--dangerous", path)

def _setup_logging(self):
Expand Down