CSS-4747 Remove the jimm snap before attempting to install it. #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ale8k
approved these changes
Jul 12, 2023
babakks
approved these changes
Jul 12, 2023
kian99
approved these changes
Jul 12, 2023
| @@ -275,6 +275,9 @@ def _install_snap(self): | |||
| if not path: | |||
| self.unit.status = BlockedStatus("waiting for jimm-snap resource") | |||
| return | |||
| # remove the jimm snap if it is already installed. | |||
| self._snap("remove", "jimm") | |||
There was a problem hiding this comment.
Could we not do a snap refresh instead?
There was a problem hiding this comment.
jimm snap is not installed from snapstore.. but instead from a resource.. i don't see a way to say "refresh from this path" using snaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The machine charm needs to remove the jimm snap (if it is installed) before installing the snap from the jimm-snap resource.
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers