Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: refactor(/data/postregesql/what-is-postgresql): Update image tags to use 'e_sharpen' #1467

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+35 −14
Open

WIP: refactor(/data/postregesql/what-is-postgresql): Update image tags to use 'e_sharpen' #1467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09f46f8
refactor(/data/postregesql/what-is-postgresql): Update image tags to …
petesfrench Dec 18, 2024
3f4a689
refactor: Use 'hi_def=False'
petesfrench Dec 18, 2024
3cb841d
test: use image_template PR as requirement for testing purposes
petesfrench Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
canonicalwebteam.flask-base==2.0.0
canonicalwebteam.blog==6.4.2
canonicalwebteam.http==1.0.4
canonicalwebteam.image-template==1.3.1
canonicalwebteam.templatefinder==1.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petesfrench Why are we removing template finder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is my mistake, I took it out as I was trying to isolate the source of a bug and forgot to put it back in.

canonicalwebteam.image-template @ git+https://github.com/canonical/canonicalwebteam.image-template/@wd-14585
canonicalwebteam.discourse==5.6.1
canonicalwebteam.search==2.1.1
bleach==5.0.1
Expand Down
46 changes: 34 additions & 12 deletions templates/data/postgresql/what-is-postgresql.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,16 @@ <h2>How do companies use PostgreSQL?</h2>
<div class="p-equal-height-row__col">
<div class="p-equal-height-row__item">
<div class="p-image-container--3-2-on-small p-image-container--square-on-medium p-image-container--2-3-on-large is-highlighted">
<img class="p-image-container__image"
src="https://assets.ubuntu.com/v1/5a4a1fb3-analytics.png"
alt="" />
<div class="p-image-container--3-2-on-small p-image-container--square-on-medium p-image-container--2-3-on-large is-highlighted">
{{ image(url="https://assets.ubuntu.com/v1/5a4a1fb3-analytics.png",
alt="",
width="568",
height="852",
hi_def=True,
attrs={"class": "p-image-container__image"},
loading="lazy") | safe
}}
</div>
</div>
</div>
<div class="p-equal-height-row__item">
Expand All @@ -131,9 +138,14 @@ <h5 class="p-heading--5">Analytics</h5>
<div class="p-equal-height-row__col">
<div class="p-equal-height-row__item">
<div class="p-image-container--3-2-on-small p-image-container--square-on-medium p-image-container--2-3-on-large is-highlighted">
<img class="p-image-container__image"
src="https://assets.ubuntu.com/v1/f43e63db-banking.png"
alt="" />
{{ image(url="https://assets.ubuntu.com/v1/f43e63db-banking.png",
alt="",
width="568",
height="852",
hi_def=True,
attrs={"class": "p-image-container__image"},
loading="lazy") | safe
}}
</div>
</div>
<div class="p-equal-height-row__item">
Expand All @@ -147,9 +159,14 @@ <h5 class="p-heading--5">Banking</h5>
<div class="p-equal-height-row__col">
<div class="p-equal-height-row__item">
<div class="p-image-container--3-2-on-small p-image-container--square-on-medium p-image-container--2-3-on-large is-highlighted">
<img class="p-image-container__image"
src="https://assets.ubuntu.com/v1/87f1a153-geospatial-data.png"
alt="" />
{{ image(url="https://assets.ubuntu.com/v1/87f1a153-geospatial-data.png",
alt="",
width="568",
height="852",
hi_def=True,
attrs={"class": "p-image-container__image"},
loading="lazy") | safe
}}
</div>
</div>
<div class="p-equal-height-row__item">
Expand All @@ -163,9 +180,14 @@ <h5 class="p-heading--5">Geospatial data</h5>
<div class="p-equal-height-row__col">
<div class="p-equal-height-row__item">
<div class="p-image-container--3-2-on-small p-image-container--square-on-medium p-image-container--2-3-on-large is-highlighted">
<img class="p-image-container__image"
src="https://assets.ubuntu.com/v1/05d1de66-search.png"
alt="" />
{{ image(url="https://assets.ubuntu.com/v1/05d1de66-search.png",
alt="",
width="568",
height="852",
hi_def=True,
attrs={"class": "p-image-container__image"},
loading="lazy") | safe
}}
</div>
</div>
<div class="p-equal-height-row__item">
Expand Down
Loading