Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: refactor(/data/postregesql/what-is-postgresql): Update image tags to use 'e_sharpen' #1467

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Dec 18, 2024

Done

This is an attempt to resolve the issue detailed here

  • Replace images using the <img> tag with the image_template() function and pass 'e_sharpen=True' to maintain quality

QA

  • Open the demo
  • Scroll down to the section 'How do companies use PostgreSQL?'
  • See that the images are sharp and have a quality that matches the images on the live site (these are using <img>, not image_template())

Issue / Card

Fixes #

@webteam-app
Copy link

@petesfrench petesfrench changed the title refactor(/data/postregesql/what-is-postgresql): Update image tags to … refactor(/data/postregesql/what-is-postgresql): Update image tags to use 'e_sharpen' Dec 18, 2024
@petesfrench petesfrench changed the title refactor(/data/postregesql/what-is-postgresql): Update image tags to use 'e_sharpen' WIP: refactor(/data/postregesql/what-is-postgresql): Update image tags to use 'e_sharpen' Dec 18, 2024
@@ -1,8 +1,7 @@
canonicalwebteam.flask-base==2.0.0
canonicalwebteam.blog==6.4.2
canonicalwebteam.http==1.0.4
canonicalwebteam.image-template==1.3.1
canonicalwebteam.templatefinder==1.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petesfrench Why are we removing template finder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is my mistake, I took it out as I was trying to isolate the source of a bug and forgot to put it back in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants