FUSETOOLS2-2113 - Allows selection of folder when creating projects #1952
Conversation
hdamarcelo
commented
Oct 5, 2024
•
hdamarcelo
commented
- Removes "enablement" for the project creation commands because we will be always choosing a folder work with.
- Project creation commands do not depend on the workspace root anymore and can be used without one.
- Refactor existing tests to use the additional folder selection dialog.
- Opens a new VSCode instance in the newly created project's folder.
|
|
hdamarcelo
force-pushed
the
FUSETOOLS2-2113
branch
3 times, most recently
from
7f7f637 to
6b37f60
Compare
src/requirements/CamelJBang.ts
Outdated
| 'export', | ||
| `--runtime=${runtime}`, | ||
| `--gav=${gav}`, | ||
| `'--directory=${outputPath}'`]); |
There was a problem hiding this comment.
to double-check the behavior when there is something in the target folder and/or when using the current folder with various version of JBang because there were some issues in the past using this parameter fr another jbang command https://issues.apache.org/jira/browse/CAMEL-21082
There was a problem hiding this comment.
Tested more locally and issue you mentioned is only solved for the init subcomand. In this JBang task we are using camel export which cleans the contents of the folder especified in the --directory= option.
hdamarcelo
force-pushed
the
FUSETOOLS2-2113
branch
3 times, most recently
from
ba4ee49 to
8c858e6
Compare
hdamarcelo
force-pushed
the
FUSETOOLS2-2113
branch
from
8c858e6 to
9a280cb
Compare
|
could you also please share the gif with Modal asking for |
|
hdamarcelo
force-pushed
the
FUSETOOLS2-2113
branch
from
9a280cb to
39d332c
Compare
|
hdamarcelo
force-pushed
the
FUSETOOLS2-2113
branch
2 times, most recently
from
304453f to
3d59111
Compare
hdamarcelo
force-pushed
the
FUSETOOLS2-2113
branch
from
3d59111 to
dc20e2d
Compare
| // Workaround for an issue during camel jbang execution in windows machines. | ||
| // Specifying the --directory option with the complete path when it is equal to the current working directory causes issues. | ||
| // Omitting the option or in this case using '.' works as expected. |
There was a problem hiding this comment.
please ensure that there is an issue in Camel Jira and provide the number of the issue in the comment.
it will allow to track more precisely it and in few years to know when we can drop this workaround code from the codebase.
There was a problem hiding this comment.
I'll update this comment with an issue number as soon as I report it.
hdamarcelo
force-pushed
the
FUSETOOLS2-2113
branch
2 times, most recently
from
7f04f26 to
9b96769
Compare
Added a check to only show the dialog if the selected folder is diferent from the first folder of the workspace (as it was before). The export command when ran from the same folder it outputs to (with --directory=.) does not delete files. |
- Removes "enablement" for the project creation commands because we will be always choosing a folder work with. - Project creation commands do not depend on the workspace root anymore and can be used without one. - Refactor existing tests to use the additional folder selection dialog. - Adds a modal to confirm the project creation since the 'camel export' command can clean the selected output folder. - Opens a new VSCode instance in the newly created project's folder. Signed-off-by: Marcelo Henrique Diniz de Araujo <[email protected]>
hdamarcelo
force-pushed
the
FUSETOOLS2-2113
branch
from
9b96769 to
78658eb
Compare
|
There was a problem hiding this comment.
Sounds fine to merge with this granularity.
2 little things:
- do not forget to report the issue and mention i tin the comment FUSETOOLS2-2113 - Allows selection of folder when creating projects #1952 (comment)
- there is no additional test provided but it seems not easy to create them as the new cases are opening a new VS Code instance. Please report a jira issue to at least have it on the radar and I hope our UI tests specialists will be able to provide a test for it
