-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Create Camel project to the welcome screen #1994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are failing on Windows
a954ac0
to
3be6363
Compare
3be6363
to
ee42f23
Compare
After some testing using a VM I was able to reproduce the error we can see in the test pipeline but unfortunately not solve it (the error is the same in PR1952) Tests I made while trying to reproduce the error:
While adding pauses in each step of the ui-test execution it seems to me that the camel jbang process ends early and does not create the pom.xml file during the test suite execution. I also tried executing camel jbang via a child process intead of using vscode's ShellExecution method but that also did not work. |
@hdamarcelo at the moment I've found 2 separate problems from VS Code point of view
for the 1. - it seems to be bug in upstream affecting mainly WINDOWS
INVALID EXPORT: VALID EXPORT also VALID for the 2. - again affecting mainly WINDOWS (or more precisely there it causes errors but the behavior is probably same everywhere..)
Hopefully it is understandable.. I know it is a bit confusing but it is kinda tricky tbh.. feel free to reach out to me in case of need and I can demo it to you 🙂 cc @apupier |
c4ac9a5
to
b2341e3
Compare
b2341e3
to
9921921
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
side-tracked and wasn't able to test it locally yet but would like to provide the initial feedback
9921921
to
7048021
Compare
} | ||
} | ||
|
||
abstract getRuntime(): Promise<string|undefined>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to decalre it as async to have a better typing and ensure that await is called.
For instance, in camel.project.command.test.ts it is not. It is causing the title of the test to be incorrect Should validate Create a Camel Project command GAV validation of [object Promise]
, see https://github.com/camel-tooling/camel-lsp-client-vscode/actions/runs/12173733325/job/33963279530?pr=1994#step:13:123
7048021
to
74e8779
Compare
- Rename NewCamelProjectCommand class to reflect its abstract nature. - Create a 'generic' NewCamelProjectCommand that asks the user to select a runtime. Register the command with 'enablement = false' so that its does not show in the command palette. - Refactor other classes with the new project structure. Signed-off-by: Marcelo Henrique Diniz de Araujo <[email protected]>
74e8779
to
40ba936
Compare
Quality Gate passedIssues Measures |
Adds Create Camel projecy to the welcome screen