sso_auth: remove email validators #252
Draft
+31
−161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As a follow up to #247, this removes some redundant logic from the sso authenticator, particularly surrounding the
AUTHORIZE_EMAIL_DOMAINS
andAUTHORIZE_EMAIL_ADDRESSES
configuration variables.Solution
AUTHORIZE_EMAIL_ADDRESSES
was only used for email validation, which is already done in the proxy so this has been removed.AUTHORIZE_EMAIL_DOMAINS
was used in two places: email validation (which has also been removed) and population of the sign in page.Rather than needing to pass these domains in as configuration variables, (or reducing the usefulness of the sign in page) sso proxy adds the allowed domains to the SignInPage URL as a query parameter, which is then parsed by sso authenticator for use within the sign in page