sso_*: move sign_in and sign_out HTML pages to sso_proxy #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
template pkg add static_files_test.go file fix TestSecurityHeaders test fix TestOAuthStart: replace template interface fix TestHTTPSRedirect partial but incomplete fix for test_provider GetSignInURL/GetSignOutURL add initial TestSignOutPage function fix sign out with no session workflow some tidyings sso_auth:additional redirect URI changes sso_auth: authenticagtor test changes sso_proxy: oauthproxy tests
Jusshersmith
force-pushed
the
jusshersmith-move-sign-in-page
branch
from
1a8eeb6
to
d6843c3
Compare
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
=========================================
- Coverage 62.51% 62.5% -0.02%
=========================================
Files 54 55 +1
Lines 4199 4211 +12
=========================================
+ Hits 2625 2632 +7
- Misses 1385 1386 +1
- Partials 189 193 +4
|
|
Marked as ready for review, but see Notes in description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current setup of html sign in and sign out pages causes some extra friction with implementing #252 - this change gives us some extra flexibility here. Also, having
sso_proxyfirst send requests tosso_auth, which subsequently renders the sign in page (and redirects back) results in extra requests and extra complexity (for example, an extra layer of nested redirects needs to be specified).Solution
Move the sign_in and sign_out HTML pages to be rendered by sso_proxy instead of sso_auth. In doing so, simplify the flow in part between
sso_proxyandsso_authenticator.Notes
This is a big change, so I'm working to add some more detailed descriptions of the changes (and going over any TODO's) to aid in better understanding them, as well as reviewing the PR in general.