Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(control): allow control type override for editor #1625

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

feat(control): allow control type override for editor #1625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions projects/novo-elements/src/elements/form/utils/FormUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,7 @@ export class FormUtils {
break;
case 'editor':
control = new EditorControl(controlConfig);
if (controlConfig.template) { control.controlType = controlConfig.template }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to recall how this is used - the template is normally a short string identifier for the template in ControlTemplates.ts that it will use, like "native-input", right?

Just trying to get an understanding of what would be some of the use cases for providing a custom override.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch was meant primarily to assist with a POC. I just needed to build it on github due to some local issues I'm having.

The template is normally a string that dictates which control template is used when rendering a control, but in the case of a dynamic for, even providing the control Type in the overrides object, eventually gets overridden when the control is instantiated.

image

The dynamic forms renders the control and searches the templates using the control type:

image

What I find to be interesting is that we do support adding custom templates, but due to this overriding behavior, there is no way to access those templates when creating a form in this manner.

break;
case 'editor-minimal':
control = new EditorControl(controlConfig);
Expand Down
Loading