feat(control): allow control type override for editor #1625
Conversation
| @@ -390,6 +390,7 @@ export class FormUtils { | |||
| break; | |||
| case 'editor': | |||
| control = new EditorControl(controlConfig); | |||
| if (controlConfig.template) { control.controlType = controlConfig.template } | |||
There was a problem hiding this comment.
Trying to recall how this is used - the template is normally a short string identifier for the template in ControlTemplates.ts that it will use, like "native-input", right?
Just trying to get an understanding of what would be some of the use cases for providing a custom override.
There was a problem hiding this comment.
This branch was meant primarily to assist with a POC. I just needed to build it on github due to some local issues I'm having.
The template is normally a string that dictates which control template is used when rendering a control, but in the case of a dynamic for, even providing the control Type in the overrides object, eventually gets overridden when the control is instantiated.
The dynamic forms renders the control and searches the templates using the control type:
What I find to be interesting is that we do support adding custom templates, but due to this overriding behavior, there is no way to access those templates when creating a form in this manner.
MichaelDill
added
the
requires discussion
Description
INSERT A SMALL DESCRIPTION OF WHAT YOU CHANGED HERE
Verify that...
npm startandnpm run buildstill worksSafari,ChromeandFirefoxnpm run lintpassesnpm testpasses and code coverage is increasednpm run buildstill worksBullhorn Internal Developers
Novo AutomationScreenshots