-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lie group capabilities to NavState #1613
base: develop
Are you sure you want to change the base?
Conversation
As a quick note, unit tests from #1582 should be added and pass |
CI also fails for Cayley variants.... |
CI fails. Can you comment on state of this PR? |
Hi, is there any plan for this ? I want to add NavState Between Factor for dynamics constraint between 2 states. My state is NavState as I want to conveniently use ImuFactor2 |
Gotcha, thanks for this amazing library btw. I kinda found a work around by setting up a hard constraint between a pose3 and NavStates Pose3 to be equal and I'm doing the between factors between the pose3. Is it an acceptable work around ? |
Hi @varunagrawal, there is an older SE2(3) implementation for GTSAM available from Bonnabel and Barrau's team: https://github.com/mbrossar/gtsam see, https://github.com/mbrossar/gtsam/blob/develop/gtsam/geometry/ExtendedPose3.h and https://github.com/mbrossar/gtsam/blob/develop/gtsam/geometry/ExtendedPose3.cpp |
Note that there is an error with coriolis term according to the paper cited above (https://ieeexplore.ieee.org/document/9519152): |
This PR makes$SE_2(3)$ Lie Group as defined in Barrau20icra.
NavState
theThere are some things that need to be completed before this PR can land:
AdjointTranspose
.retract
andlocalCoordinates
. Specifically, need to derive the jacobians and verify they are the same as Barrau20icra.retract
andlocalCoordinates
, lots of unit tests fail, so it is important to check this too.