Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix joint command resampling and conversion #46

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

texhnolyze
Copy link
Contributor

@texhnolyze texhnolyze commented Dec 12, 2024

Proposed changes

  • fix(import): conversion of -pi..pi to 0..2pi
  • fix(import): error before saving to db on empty data
  • fix(resampling): interpolate JointConmmands on a per joint basis
    as the /DynamixelControl/command messages do not always contain all
    while still keeping the same synced timing with IMU and JointState
    data.
    This also means we start saving data only once all joints have been
    moved (torso + head).

as the `/DynamixelControl/command` messages do not always contain all
while still keeping the same synced timing with IMU and `JointState`
data.

This also means we start saving data only once all joints have been
moved (torso + head).
@texhnolyze texhnolyze requested review from Flova and jaagut December 12, 2024 18:36
@texhnolyze texhnolyze self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant