-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: noValueAtRule css lint rule #3293
base: main
Are you sure you want to change the base?
feat: noValueAtRule css lint rule #3293
Conversation
Sorry, I forgot to mention that it seems now it's impossible to get a parser option inside in a rule. |
@denbezrukov I would like to pick up autofixing as part of seperate PR. It seems to be much more involved. Adding findings here for future reference:
|
If you want to land the code action in another PR, I would suggest to not close the original issue or opening a new one. |
CodSpeed Performance ReportMerging #3293 will degrade performances by 6.93%Comparing Summary
Benchmarks breakdown
|
4b5d5d9
to
7081ec2
Compare
7081ec2
to
8f4f8be
Compare
A couple of things:
|
Summary
Implements
noValueAtRule
lint rule for css modulesTODO:
Run this rule only when used inside css_modules (i.e. when enabled in parser options)Test Plan
Refers #3001