chore: resolve comments

biomejs · Jul 6, 2024 · 7081ec2 · 7081ec2
1 parent 499df25
commit 7081ec2
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 14 deletions.
diff --git a/crates/biome_css_analyze/src/lint/nursery/no_value_at_rule.rs b/crates/biome_css_analyze/src/lint/nursery/no_value_at_rule.rs
@@ -4,9 +4,9 @@ use biome_css_syntax::CssAtRule;
 use biome_rowan::AstNode;
 
 declare_rule! {
-    /// Disallow use of @value rule in css modules
+    /// Disallow use of `@value` rule in css modules.
     ///
-    /// Use of CSS variables is recommeneded instead of @value rule
+    /// Use of CSS variables is recommended instead of `@value` rule.
     ///
     /// ## Examples
     ///
@@ -59,7 +59,7 @@ impl Rule for NoValueAtRule {
                 rule_category!(),
                 span,
                 markup! {
-                    "Unexpected @value rule"
+                    "Use of "<Emphasis>"@value"</Emphasis>" rule is disallowed"
                 },
             )
             .note(markup! {

diff --git a/...noValueAtRule/invalid.module.css.snap.new → ...ery/noValueAtRule/invalid.module.css.snap b/...noValueAtRule/invalid.module.css.snap.new → ...ery/noValueAtRule/invalid.module.css.snap
@@ -1,6 +1,5 @@
 ---
 source: crates/biome_css_analyze/tests/spec_tests.rs
-assertion_line: 92
 expression: invalid.module.css
 ---
 # Input
@@ -29,7 +28,7 @@ expression: invalid.module.css
 ```
 invalid.module.css:2:1 lint/nursery/noValueAtRule ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  ! Unexpected @value rule
+  ! Use of @value rule is disallowed
   
     1 │ /* css variables */
   > 2 │ @value primary: #BF4040;
@@ -47,7 +46,7 @@ invalid.module.css:2:1 lint/nursery/noValueAtRule ━━━━━━━━━━
 ```
 invalid.module.css:3:1 lint/nursery/noValueAtRule ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  ! Unexpected @value rule
+  ! Use of @value rule is disallowed
   
     1 │ /* css variables */
     2 │ @value primary: #BF4040;
@@ -66,7 +65,7 @@ invalid.module.css:3:1 lint/nursery/noValueAtRule ━━━━━━━━━━
 ```
 invalid.module.css:6:1 lint/nursery/noValueAtRule ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  ! Unexpected @value rule
+  ! Use of @value rule is disallowed
   
     5 │ /* breakpoints */
   > 6 │ @value small: (max-width: 599px);
@@ -84,7 +83,7 @@ invalid.module.css:6:1 lint/nursery/noValueAtRule ━━━━━━━━━━
 ```
 invalid.module.css:7:1 lint/nursery/noValueAtRule ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  ! Unexpected @value rule
+  ! Use of @value rule is disallowed
   
     5 │ /* breakpoints */
     6 │ @value small: (max-width: 599px);
@@ -103,7 +102,7 @@ invalid.module.css:7:1 lint/nursery/noValueAtRule ━━━━━━━━━━
 ```
 invalid.module.css:8:1 lint/nursery/noValueAtRule ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  ! Unexpected @value rule
+  ! Use of @value rule is disallowed
   
      6 │ @value small: (max-width: 599px);
      7 │ @value medium: (min-width: 600px) and (max-width: 959px);
@@ -122,7 +121,7 @@ invalid.module.css:8:1 lint/nursery/noValueAtRule ━━━━━━━━━━
 ```
 invalid.module.css:11:1 lint/nursery/noValueAtRule ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  ! Unexpected @value rule
+  ! Use of @value rule is disallowed
   
     10 │ /* alias paths for other values or composition */
   > 11 │ @value colors: "./colors.css";
@@ -140,7 +139,7 @@ invalid.module.css:11:1 lint/nursery/noValueAtRule ━━━━━━━━━
 ```
 invalid.module.css:13:1 lint/nursery/noValueAtRule ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  ! Unexpected @value rule
+  ! Use of @value rule is disallowed
   
     11 │ @value colors: "./colors.css";
     12 │ /* import multiple from a single file */
@@ -159,7 +158,7 @@ invalid.module.css:13:1 lint/nursery/noValueAtRule ━━━━━━━━━
 ```
 invalid.module.css:15:1 lint/nursery/noValueAtRule ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  ! Unexpected @value rule
+  ! Use of @value rule is disallowed
   
     13 │ @value primary, secondary from colors;
     14 │ /* make local aliases to imported values */
@@ -178,7 +177,7 @@ invalid.module.css:15:1 lint/nursery/noValueAtRule ━━━━━━━━━
 ```
 invalid.module.css:17:1 lint/nursery/noValueAtRule ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  ! Unexpected @value rule
+  ! Use of @value rule is disallowed
   
     15 │ @value small as bp-small, large as bp-large from "./breakpoints.css";
     16 │ /* value as selector name */

diff --git a/...y/noValueAtRule/valid.module.css.snap.new → ...rsery/noValueAtRule/valid.module.css.snap b/...y/noValueAtRule/valid.module.css.snap.new → ...rsery/noValueAtRule/valid.module.css.snap
@@ -1,6 +1,5 @@
 ---
 source: crates/biome_css_analyze/tests/spec_tests.rs
-assertion_line: 92
 expression: valid.module.css
 ---
 # Input