Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] pkgmeta: Support PEP-610 direct_url.json #319

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

ales-erjavec
Copy link
Collaborator

Issue

Fixes: #317

Since some time pip install -e ... installs a ${NAME}.dist-info dir into site-packages with a direct_url.json recording its origin.
This confuses importlib.metadata (python/cpython#96144)

Changes

Support PEP-610 direct_url.json

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 10 lines in your changes missing coverage. Please review.

Project coverage is 76.58%. Comparing base (70e3d16) to head (48d4747).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
orangecanvas/utils/pkgmeta.py 64.00% 9 Missing ⚠️
orangecanvas/help/manager.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   76.60%   76.58%   -0.03%     
==========================================
  Files         100      100              
  Lines       21217    21240      +23     
==========================================
+ Hits        16253    16266      +13     
- Misses       4964     4974      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markotoplak
Copy link
Member

Thanks! Works immediately for me on orange3, orange-spectroscopy, orange3-imageanalytics.

Did not work with orange3-fairness, but there I saw a warning DEPRECATION: Legacy editable install of Orange3-Fairness==1.0.1 from file:///home/marko/dev/orange3-fairness (setup.py develop) is deprecated. pip 25.0 will enforce this behaviour change. A possible replacement is to add a pyproject.toml or enable --use-pep517, and use setuptools >= 64. If the resulting installation is not behaving as expected, try using --config-settings editable_mode=compat. Please consult the setuptools documentation for more information. Discussion can be found at https://github.com/pypa/pip/issues/11457

I could fix the orange3-fairness, though, to use the newer way.

@markotoplak markotoplak merged commit 86724ab into biolab:master Dec 9, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help for packages installed in dev mode does not work
3 participants