Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use const arrays with dynamic indexes, shader code cleanup #16174

Open
BenjaminBrienen opened this issue Oct 30, 2024 · 0 comments
Open

Use const arrays with dynamic indexes, shader code cleanup #16174

BenjaminBrienen opened this issue Oct 30, 2024 · 0 comments
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Shaders This code uses GPU shader languages S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Milestone
0.16

Comments

@BenjaminBrienen
Copy link
Contributor

Something we can finally now do is use const arrays with dynamic indexes, for e.g. shadow sampling patterns.

We should take advantage of this to cleanup a bunch of shader code.

Originally posted by @JMS55 in #15988 (comment)
@BenjaminBrienen BenjaminBrienen added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Shaders This code uses GPU shader languages S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Oct 30, 2024
@BenjaminBrienen BenjaminBrienen added this to the 0.16 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Shaders This code uses GPU shader languages S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
0.16
Development

No branches or pull requests
1 participant
@BenjaminBrienen