Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dirty fix for App hanging when windows are invisible on WindowsOS #14155

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Dirty fix for App hanging when windows are invisible on WindowsOS #14155

wants to merge 4 commits into from
+9 −1

Conversation

MiniaczQ
Copy link
Contributor

@MiniaczQ MiniaczQ commented Jul 5, 2024 •
edited
Loading

Objective

Solution

  • If no windows are visible, app updates will run regardless of redraw call result.

This a relatively dirty fix, a more robust solution is desired in the long run:
#1343 (comment)
https://discord.com/channels/691052431525675048/1253771396832821270/1258805997011730472
The solution would disconnect rendering from app updates.

Testing

  • window_settings now works

Other platforms

Not a problem on Linux: https://discord.com/channels/691052431525675048/692572690833473578/1259526650622640160
Not a problem on MacOS: https://discord.com/channels/691052431525675048/692572690833473578/1259563986148659272

@janhohenheim janhohenheim added C-Bug An unexpected or incorrect behavior A-Windowing Platform-agnostic interface layer to run your app in D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward O-Windows Specific to the Windows desktop operating system labels Jul 5, 2024
@alice-i-cecile alice-i-cecile added this to the 0.14.1 milestone Jul 7, 2024
@alice-i-cecile
Copy link
Member

Can you create an issue for the proper fix and link it here please?

@alice-i-cecile alice-i-cecile added the A-Networking Sending data between clients, servers and machines label Jul 7, 2024
@alice-i-cecile
Copy link
Member

This is a vital fix for 0.14.1, because of the impact on servers in networked games.

@MiniaczQ
Copy link
Contributor Author

MiniaczQ commented Jul 7, 2024

This is a vital fix for 0.14.1, because of the impact on servers in networked games.

Actually, a headless server works just fine, it's only when we try to use a window driven event loop with invisible windows

@alice-i-cecile alice-i-cecile modified the milestones: 0.14.1, 0.15 Jul 7, 2024
@alice-i-cecile alice-i-cecile removed the A-Networking Sending data between clients, servers and machines label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples O-Windows Specific to the Windows desktop operating system S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.

visible: false on WindowPlugin Stops Rendering
3 participants
@MiniaczQ @alice-i-cecile @janhohenheim