Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Examples Screenshots #1530

Merged
merged 3 commits into from
Jul 13, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 4, 2024

This PR updates the screenshots of the examples with latest version from Bevy.
It was automatically generated by a GitHub Action.

@BD103
Copy link
Member

BD103 commented Jul 4, 2024

It would be good to run pngcrush or another image optimization tool on these, before it gets merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there supposed to be a giant white polygon in the sky?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. I don't remember the reason, but I remember @superdump is related to "giant white polygon in the sky"

@mockersf
Copy link
Member

mockersf commented Jul 4, 2024

It would be good to run pngcrush or another image optimization tool on these, before it gets merged.

I crushed it manually for this time, we could update the action to do it automatically for next.

@Chubercik
Copy link
Contributor

It would be good to run pngcrush or another image optimization tool on these, before it gets merged.

@rparrett rparrett added S-Ready-For-Final-Review Ready for a maintainer to consider for merging and removed S-Needs-Review labels Jul 13, 2024
@mockersf mockersf added this pull request to the merge queue Jul 13, 2024
Merged via the queue into main with commit d147084 Jul 13, 2024
10 checks passed
@mockersf mockersf deleted the create-pull-request/patch-aufy2xb branch July 13, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants