Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically run pngcrush on example screenshots #1534

Closed
BD103 opened this issue Jul 4, 2024 · 1 comment · Fixed by #1547
Closed

Automatically run pngcrush on example screenshots #1534

BD103 opened this issue Jul 4, 2024 · 1 comment · Fixed by #1547
Labels
A-Release-Notes C-Automation Tools to make repetitive tasks easier

Comments

@BD103
Copy link
Member

BD103 commented Jul 4, 2024

It would be good to run pngcrush or another image optimization tool on these, before it gets merged.

I crushed it manually for this time, we could update the action to do it automatically for next.

Originally posted by @mockersf in #1530 (comment)
@BD103 BD103 changed the title > It would be good to run pngcrush or another image optimization tool on these, before it gets merged. Automatically run pngcrush on example screenshots Jul 4, 2024
@alice-i-cecile alice-i-cecile added C-Automation Tools to make repetitive tasks easier A-Release-Notes labels Jul 5, 2024
@ilyvion
Copy link

ilyvion commented Jul 6, 2024

Consider using oxipng, if for no other reason than that it's written in Rust. (/s) I'm kidding, it's both fast and produces good results!

@Chubercik Chubercik mentioned this issue Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Release-Notes C-Automation Tools to make repetitive tasks easier
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automatically run oxipng on example screenshots Chubercik/bevy-website
3 participants
@ilyvion @alice-i-cecile @BD103