Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4211 - Adding collaborators refresh list #4349

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

WillNigel23
Copy link
Collaborator

No description provided.

@WillNigel23 WillNigel23 linked an issue Sep 24, 2024 that may be closed by this pull request
cssclass: null, // Custom CSS class for the litebox
noscroll: true, // Disable page scroll when open
disposable: false, // Remove from DOM after close
noclose: false // Remove close button
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added noclose for litebox prototype

this.$wrapper.add(this.$closebutton).on('click', $.proxy(this.eventClose, this));
this.$container.click(function(e) { e.stopPropagation(); });
this.$container.append(this.$closebutton, this.$content);
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines 92-99

If noclose option passed, we do not add closebutton

@WillNigel23
Copy link
Collaborator Author

The diff on the js seems broken (due to empty spaces I assume?)

I marked with comments the lines that I changed. Sorry in advance 🙏

@benwbrum @saracarl

Copy link
Collaborator

@saracarl saracarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the same thing with collection owners?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding collaborators doesn't refresh the list in the UI
2 participants