Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding collaborators doesn't refresh the list in the UI #4211

Open
saracarl opened this issue Jul 8, 2024 · 1 comment · May be fixed by #4349
Open

adding collaborators doesn't refresh the list in the UI #4211

saracarl opened this issue Jul 8, 2024 · 1 comment · May be fixed by #4349
Assignees
Labels

Comments

@saracarl
Copy link
Collaborator

saracarl commented Jul 8, 2024

If you add a collaborator in the collection settings, i.e. https://fromthepage.com/sylvia-kollar/1890-police-census/edit/privacy#
the list doesn't refresh.

(Please check for the same thing in owners)

@WillNigel23
Copy link
Collaborator

As per discussion, list works correctly.

Probable cause of confusion here is the 'x' button, where clicking that closes the modal without page refresh and thus user might feel like the list did not update.

As per discussion, we will remove the 'x' button for collaborators modals so that users are forced to click Done instead.

@saracarl @benwbrum

@WillNigel23 WillNigel23 linked a pull request Sep 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants