Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/devsu 2216 include recruitment status in kbmatches #144

Merged

Conversation

elewis2
Copy link
Collaborator

@elewis2 elewis2 commented Feb 15, 2024

Adds recruitment_status to kb_data field in kbmatches, where it's available.

Tested with gsc_report.

@codecov-commenter
Copy link

Codecov Report

Attention: 165 lines in your changes are missing coverage. Please review.

Comparison is base (501c931) 91.16% compared to head (1cbea98) 53.34%.
Report is 153 commits behind head on develop.

Files Patch % Lines
ipr/main.py 5.64% 117 Missing ⚠️
ipr/annotate.py 43.58% 22 Missing ⚠️
ipr/ipr.py 52.94% 16 Missing ⚠️
ipr/summary.py 0.00% 9 Missing ⚠️
ipr/connection.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #144       +/-   ##
============================================
- Coverage    91.16%   53.34%   -37.82%     
============================================
  Files            8       10        +2     
  Lines         1086     1269      +183     
============================================
- Hits           990      677      -313     
- Misses          96      592      +496     
Flag Coverage Δ
unittests 53.34% <23.61%> (-37.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elewis2 elewis2 merged commit 618372a into develop Feb 15, 2024
7 checks passed
@elewis2 elewis2 deleted the feature/DEVSU-2216-include-recruitment-status-in-kbmatches branch February 15, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants