Check earlier for log device #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmbarros
force-pushed
the
lmb/check-earlier
branch
2 times, most recently
from
a779c71 to
7908cca
Compare
This is in preparation for a bigger change that will come next. Signed-off-by: Leandro Motta Barros <[email protected]> Change-type: patch
Previously, we'd check for the log device (passed with `--log-to`) only after the user confirmed to proceed with the migration. And then, if the device was not valid, takeover would keep running without storing the stage 2 logs anywhere. In other words, a mistake in the command-line arguments could cause important logs to be lost. With this commit, we check the the log device at a much earlier point (before asking the user for confirmation to proceed), and if the device provided is no good, we log an error message and exit. This allows the user to fix the command-line arguments and run again. Signed-off-by: Leandro Motta Barros <[email protected]> Change-type: minor
lmbarros
force-pushed
the
lmb/check-earlier
branch
from
7908cca to
34febb5
Compare
rahul-thakoor
approved these changes
May 3, 2024
There was a problem hiding this comment.
Tested:
-
no log device
2024-05-03 04:37:27 INFO Early checks passed -
no partition
2024-05-03 04:43:04 ERROR [takeover::stage1] The log device '/dev/sda' is not a partition, so it can't be used for stage 2 logs
2024-05-03 04:43:04 ERROR [takeover::stage1::checks] the requested log device is not suitable for writing stage2 logs
2024-05-03 04:43:04 ERROR [takeover] Migrate stage 1 returned an error: An error occurred in an upstream function, context: Failed early checks, exiting
caused by: The error was displayed upstream
- partition
2024-05-03 04:44:52 DEBUG [takeover::stage1::block_device_info::partition] PartitionInfo::new: for /dev/sda1 got PartitionInfo { uuid: Some("03CF-0DFD"), block_size: Some(512), fs_type: Some("vfat"), label: None, part_uuid: None }
2024-05-03 04:44:52 DEBUG [takeover::stage1::block_device_info] found partition '"sda1"' in '/sys/block/sda/sda1'
2024-05-03 04:44:52 DEBUG [takeover::stage1::block_device_info] new: got device: BlockDevice { name: "sda", device_num: DeviceNum { major: 8, minor: 0 }, mounted: None, parent: "None" }
2024-05-03 04:44:52 INFO Early checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we'd check for the log device (passed with
--log-to) onlyafter the user confirmed to proceed with the migration. And then, if the
device was not valid, takeover would keep running without storing the
stage 2 logs anywhere.
In other words, a mistake in the command-line arguments could cause
important logs to be lost.
With this commit, we check the the log device at a much earlier point
(before asking the user for confirmation to proceed), and if the device
provided is no good, we log an error message and exit. This allows the
user to fix the command-line arguments and run again.