Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device passed to --log-to is checked only when already entering stage 2 #57

Closed
lmbarros opened this issue Feb 19, 2024 · 1 comment
Closed

Comments

@lmbarros
Copy link
Contributor

This is an usability issue. If I pass an invalid value to --log-to, I get a warning only after takeover is already entering stage 2, so I can't safely stop the process and fix my mistake.

Ideally, the validity of the argument should be checked earlier on. And I guess that by default (unless we also pass --no-ack?) we should stop the execution if the argument is not valid.

@rahul-thakoor
Copy link
Contributor

closed by #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants