Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 New EC2 Instances with Recommended Configuration #476

Closed
wants to merge 7 commits into from
Closed

4 New EC2 Instances with Recommended Configuration #476

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2e79e42
add new platorms
waahm7 Dec 12, 2024
f30e6b4
remove U
waahm7 Dec 12, 2024
fc76c7d
Merge branch 'main' into new-instance-types-2
waahm7 Dec 12, 2024
065fe3d
fix _.
waahm7 Dec 13, 2024
70cdf46
just make it explicit
waahm7 Dec 13, 2024
26d77cc
remove copy paste doc
waahm7 Dec 13, 2024
f46b40d
fix unit
waahm7 Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 43 additions & 7 deletions source/s3_platform_info.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@
/**** Configuration info for the c5n.18xlarge *****/
static struct aws_s3_platform_info s_c5n_18xlarge_platform_info = {
.instance_type = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("c5n.18xlarge"),
.max_throughput_gbps = 100u,
.max_throughput_gbps = 100,
/** not yet **/
.has_recommended_configuration = false,
};

static struct aws_s3_platform_info s_c5n_metal_platform_info = {
.instance_type = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("c5n.metal"),
.max_throughput_gbps = 100u,
.max_throughput_gbps = 100,
/** not yet **/
.has_recommended_configuration = false,
};
Expand All @@ -34,7 +34,7 @@ static struct aws_s3_platform_info s_c5n_metal_platform_info = {
/****** Begin c5n.large ******/
static struct aws_s3_platform_info s_c5n_9xlarge_platform_info = {
.instance_type = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("c5n.9xlarge"),
.max_throughput_gbps = 50u,
.max_throughput_gbps = 50,
/** not yet **/
.has_recommended_configuration = false,
};
Expand All @@ -44,19 +44,19 @@ static struct aws_s3_platform_info s_c5n_9xlarge_platform_info = {
/***** Begin p4d.24xlarge and p4de.24xlarge ****/
static struct aws_s3_platform_info s_p4d_platform_info = {
.instance_type = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("p4d.24xlarge"),
.max_throughput_gbps = 400u,
.max_throughput_gbps = 400,
.has_recommended_configuration = true,
};

static struct aws_s3_platform_info s_p4de_platform_info = {
.instance_type = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("p4de.24xlarge"),
.max_throughput_gbps = 400u,
.max_throughput_gbps = 400,
.has_recommended_configuration = true,
};

/***** End p4d.24xlarge and p4de.24xlarge ****/

/***** Begin p5.48xlarge ******/
/***** Begin p5_.48xlarge ******/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's with having both _ and . ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a section for the p5 family, so _ means p5+(e/en etc), and . is part of the instance name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have gotten rid of _ since it was confusing and made the sections explicit.


/* note: the p5 is a stunningly massive instance type.
* While the specs have 3.2 TB/s for the network bandwidth
Expand All @@ -68,11 +68,43 @@ static struct aws_s3_platform_info s_p4de_platform_info = {
* to the p4d. The rest is for other things on the machine to use. */
struct aws_s3_platform_info s_p5_platform_info = {
.instance_type = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("p5.48xlarge"),
.max_throughput_gbps = 400U,
.max_throughput_gbps = 400,
.has_recommended_configuration = true,
};

struct aws_s3_platform_info s_p5e_platform_info = {
.instance_type = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("p5e.48xlarge"),
.max_throughput_gbps = 400,
.has_recommended_configuration = true,
};

struct aws_s3_platform_info s_p5en_platform_info = {
.instance_type = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("p5en.48xlarge"),
.max_throughput_gbps = 400,
.has_recommended_configuration = true,
};
/***** End p5.48xlarge *****/

/**** Begin trn2_48_large *****/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial: why switch from . to _ in these comments? (this repeats again in the End comment)

/*
* Similar to P5 comment above, we will not be able to get the advertised 3.2Tb bandwidth from CPU.
*/
static struct aws_s3_platform_info s_trn2_platform_info = {
.instance_type = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("trn2.48xlarge"),
/* not all of the advertised 1600 Gbps bandwidth can be hit from the cpu in user-space */
.max_throughput_gbps = 400,
.has_recommended_configuration = true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to coordinate with python teams on this...

};

static struct aws_s3_platform_info s_trn2u_platform_info = {
.instance_type = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("trn2u.48xlarge"),
/* not all of the advertised 800 Gbps bandwidth can be hit from the cpu in user-space */
.max_throughput_gbps = 400,
.has_recommended_configuration = true,
};

/**** End trn2_48_large *****/

/**** Begin trn1_32_large *****/
static struct aws_s3_platform_info s_trn1_n_platform_info = {
.instance_type = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("trn1n.32xlarge"),
Expand Down Expand Up @@ -186,6 +218,10 @@ struct aws_s3_platform_info_loader *aws_s3_platform_info_loader_new(struct aws_a
s_add_platform_info_to_table(loader, &s_p4d_platform_info);
s_add_platform_info_to_table(loader, &s_p4de_platform_info);
s_add_platform_info_to_table(loader, &s_p5_platform_info);
s_add_platform_info_to_table(loader, &s_p5e_platform_info);
s_add_platform_info_to_table(loader, &s_p5en_platform_info);
s_add_platform_info_to_table(loader, &s_trn2_platform_info);
s_add_platform_info_to_table(loader, &s_trn2u_platform_info);
s_add_platform_info_to_table(loader, &s_trn1_n_platform_info);
s_add_platform_info_to_table(loader, &s_trn1_platform_info);

Expand Down